Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TypeSourceSelector.cs #230

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

peterhel
Copy link

dotnet/SqlClient#1930

I had the same issue here. After changing to GetExportedTypes() seems to fix the issue

Hey! Got into trouble with .NET 8. If you look through the thread above you can see why I made the proposed change.

dotnet/SqlClient#1930

> I had the same issue here. After changing to GetExportedTypes() seems to fix the issue
@khellang
Copy link
Owner

Hi @peterhel! 👋🏻

Thanks for this contribution 🙏🏻 Unfortunately, it looks like there's a syntax error and build is failing 😅

Copy link

@121GWJolt 121GWJolt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried to apply a fix since it was only a missing closing parenthesis!

@@ -154,7 +154,7 @@ private IImplementationTypeSelector InternalFromAssembliesOf(IEnumerable<Type> t

private IImplementationTypeSelector InternalFromAssemblies(IEnumerable<Assembly> assemblies)
{
return AddSelector(assemblies.SelectMany(asm => asm.DefinedTypes).Select(x => x.AsType()));
return AddSelector(assemblies.SelectMany(asm => asm.ExportedTypes);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return AddSelector(assemblies.SelectMany(asm => asm.ExportedTypes);
return AddSelector(assemblies.SelectMany(asm => asm.ExportedTypes));

This should fix the build error!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants